cpp-linter / cpp-linter-action

A Github Action for linting C/C++ code integrating clang-tidy and clang-format to collect feedback provided in the form of file-annotations, thread-comments, workflow step-summary, and Pull Request reviews.

https://cpp-linter.github.io/cpp-linter-action/

Cannot get comments displayed on github/pull page

malaterre opened this issue a year ago · comments

Mathieu Malaterre commented a year ago

For some reason I do not see any clang-tidy bot comment on my github/pull page:

malaterre/libdicm#48

Using the following setup:

https://github.com/malaterre/libdicm/blob/9c109fc73cf75473374f51f6afd6d2043a89458e/.github/workflows/clang-tidy-review.yml

Am I missing something from the documentation ? Thanks much

Brendan commented a year ago

The thread-comments option is disabled by default. You need to add

thread-comments: true

to your config.

Brendan commented a year ago

Currently, there won't be any comment if all checks pass. We will be changing that though (see cpp-linter/cpp-linter#24)

Peter Shen commented a year ago

Please feel free to reopen if any further questions or problems.

Mathieu Malaterre commented a year ago

Just one last comment, why is GITHUB_TOKEN required ? It seems some alternatives manage to get it working without it explicitly:

https://github.com/marketplace/actions/clang-tidy-review#inputs

Brendan commented a year ago

I suppose we could try using it implicitly (haven't considered it). I personally prefer users know when write/read privileges are being used by a third party.