Why all checks have passed?

[서벨롭]

hello,

Why all checks have passed?

I want to raise an error if the ansi rule is not met.

name: C Code Convention CI

on: [push]

jobs:
  cpp-linter:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: cpp-linter/cpp-linter-action@v2
        id: linter
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          style: file
          extensions: c,C,h,H
          extra-args: -Wall -Wextra -ansi -c

      - name: Fail fast?!
        if: steps.linter.outputs.checks-failed > 0
        run: echo "Some files failed the linting checks!"

Create a.c

[Brendan]

You need to change the "Fail fast?!" step in your workflow.

       - name: Fail fast?!
         if: steps.linter.outputs.checks-failed > 0
-        run: echo "Some files failed the linting checks!"
+        run: exit 1

[Brendan]

I want to raise an error if the ansi rule is not met.

If you only want to raise an error for a specific rule (and not for other rules), then this might be done in your workflow by running cpp-linter twice -- once for rules that don't raise an error, and once for the ANSI rule(s) that should raise an error. This can be done as 2 separate jobs in the same workflow.

But this is not a problem with the cpp-linter-action because there is no support in clang-tidy to give a higher "rank" to certain rules and a lower "rank" to others.

[서벨롭]

You need to change the "Fail fast?!" step in your workflow.

       - name: Fail fast?!
         if: steps.linter.outputs.checks-failed > 0
-        run: echo "Some files failed the linting checks!"
+        run: exit 1

Thank you for your valuable time.

Close the issue by solving the problem.