couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.

Home Page:https://couler-proj.github.io/couler/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove the `args` field from `Container`

moshewe opened this issue · comments

Summary

According to the Argo documentation, container doesn't have an args field at all. It's used to put input parameters, with the input field used to put input artifacts (pulled in from the run_container method). It's counter-intuitive. I think a better solution would be to use the input field solely for the purpose of defining template inputs.

Use Cases

Better alignment with Argo docs, more intuitive code design and more fine grained container template definitions.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

Would you like to propose changes that are backwards compatible and perhaps add a deprecation warning?

Deprecating it sounds like a good idea.