couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.

Home Page:https://couler-proj.github.io/couler/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

couler.set_dependencies do not set dependencies correctly

zjjott opened this issue · comments

Summary

when set_dependencies None dep, have no deal with this issue
minimal Reproducible code:

        couler.set_dependencies(
            lambda: job_a(message="A"), dependencies=None
        )
        couler.set_dependencies(
            lambda: job_b(message="B"), dependencies="A.Succeeded"
        )
        couler.set_dependencies(
            lambda: job_c(message="C"), dependencies=None
        )

What happened/what you expected to happen?

        wf_tree = couler.workflow_yaml()
        tasks = wf_tree["spec"]["templates"][0]["dag"]["tasks"]
        deps = tasks[2].get("dependencies")

Before my pr, deps will be B ,but it should be None

Diagnostics

What is the version of Couler you are using?
master branch

I'll fix it
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.