cosmos / chain-registry

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing `image` field on https://chains.cosmos.directory

jo-chainmasters opened this issue · comments

Hey friends,
since i updated the registry about the Unification Blockchain, Unification is not showing on ReStake.
I digged into it and found the following:
ReStake is showing only 122 of 132 Networks on the Startpage. After debugging i know they showing network only if the image field of a network has data.
Yes, its maybe an issue of the ReStake UI, but i debugged a little more and found the following:
According due to the chain schema and assetlist schema there is no field image. Only an array images. I guess image is something from the past.
But if i check https://chains.cosmos.directory/ the images array is not served. So there is no chance for other projects to get the image paths.
For a lot of networks and assets image is served, but not for Unification because i dont filled that field because its not in the schema.
I will raise a ticket at ReStake too because it makes no sense to not display a Network if no logo is served. But i think we should start at the registry to clean the situation. I can understand that image will be served (down compatibility), but images should be served too i think?. (Otherwise it makes no sense to have it in the schema).

Or maybe its an issue with aggregation of the data? Maybe image is auto-generated and depends on anything which is missing in the Unification chain JSON?

Yes for the time being we should maintain the logo_URIs property that most systems are used to querying. Images will have advanced capability but the logo_URIs property should still remain

This should be resolved now?
#2883

So maybe we should add logo_URIs to the schema files too (temporary)? Not sure if it will resolve the issue. Is image assembled at/on/by logo_URIs? If so, then yes, it would resolve the issue. But i have seen some networks has added a image field directly on the chain JSON file. So, im not sure if image on the final output of https://chains.cosmos.directory will be just one by one the image field of the chain JSON.

Yes, for now we'll make sure any usage of images also has the logo_URIs property as well. Interfaces can continue to pull directly from the logo_URIs property and images will only be used to inform scripts to make updates to the logo_URIs property where appropriate.

Seems to be resolved