cosmos / chain-registry

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

duplicated tokens on chain-registry

marslavish opened this issue · comments

For example, there're two ATOM tokens, one is the governance token on Carbon:
image
and the other is the native token of the Cosmos Hub
image

I find it odd we're including IBC denoms in the asset list? This ends up making duplicate ATOM tokens. I think I can filter it out on npm side, but I haven't seen this except for cw in juno before.

"symbol": "ATOM",

cc @JeremyParish69

@JeremyParish69 for persistence, this is fine, because we handled the special case. However, we should be using the npm module for generating IBC denoms... or maybe we can look at other solutions. But currently this type of asset list is creating duplicates. I would suggest we only include "native" tokens in the assetlist, or we make an ibcassets.json that has these tokens that aren't meant to be "native".

Proposed solution is to add another asset type 'ics_20' #1538

This can now be filtered by the 'ics20' value for the type_asset enum