cosmology-tech / starship

A k8s based unified development environment for Cosmos Ecosystem (and beyond)

Home Page:https://docs.cosmology.zone/starship

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

cleanup: `config.go` defining the config file for Starship multiple defination

Anmol1696 opened this issue · comments

Overview

For parsing the config file that we provide Starship users, there are already 3 internal implementations of the same. Which are:

  • clients/go/client/config.go
  • cmd/starship/
  • tests/e2e/config.go

Proposal

Unify the configs to be part of a common pkg or something. Note can just be part of the starship client itself, but would have to live outside the cmd/ dir.

Option 1

With #229, we can have a dedicated config pkg available at: pkg/config/helm.go. Inorder to make it independently importatble might have to create a go.mod for it seperately itself.

Option 2

Create a proto from the values.schema.json, and use the proto complilation as config definations. Can be available at types/ dir at root.