cortexproject / cortex

A horizontally scalable, highly available, multi-tenant, long term Prometheus.

Home Page:https://cortexmetrics.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecate `querier.ingester-streaming` flag and always use QueryStream

yeya24 opened this issue · comments

Deprecate flag querier.ingester-streaming which enables Ingester Query Streaming.

This will also remove the Query method from the Distributor Read interface
https://github.com/cortexproject/cortex/blob/master/pkg/querier/distributor_queryable.go#L29C2-L29C7.

This flag was also marked as the default option 4 years ago in https://github.com/cortexproject/cortex/pull/2344/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR55.

It should be the time to always turn it on to remove some unnecessary code.

The plan is to mark this flag as deprecated in v1.17.0 and totally remove it in v1.19.0.