cortexproject / cortex

A horizontally scalable, highly available, multi-tenant, long term Prometheus.

Home Page:https://cortexmetrics.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

1.16.0 Store Gateway Query stats - ability to disable

philiptrovato opened this issue · comments

Describe the bug
New Store Gateway Query stats are pretty cool, but verbose and generate an excessive amounts of logs. No current flags to disable from what I can tell, must be turned off by setting log level to "warn".

Querier: Log query stats when querying store gateway. #5376

To Reproduce
Steps to reproduce the behavior:

  1. Run Cortex v1.16.0 at info log level
  2. Perform query or ruler operations which hit the SGW

Expected behavior
Expected the new SGW query stats to follow the flag "query_stats_enabled"
Or have its own flag to disable.
Or have the new SGW query stats set at debug level instead of info.

That's a good call.
query_stats_enabled is a flag used in QFE only. I prefer to add a new flag for store gateway stats log.