Remove text "Die hier gezeigten Schnelltestzentren werden täglich aktualisiert"

Question

Remove text "Die hier gezeigten Schnelltestzentren werden täglich aktualisiert"

Ein-Tim opened this issue 2 years ago · comments

Current Implementation

Currently on https://map.schnelltestportal.de on the top it says: "Die hier gezeigten Schnelltestzentren werden täglich aktualisiert".

Suggested Enhancement

I would suggest to remove this text or replace it with another text, as there are quite some data quality issues (see #19).

Expected Benefits

The text "Die hier gezeigten Schnelltestzentren werden täglich aktualisiert" may be misleading to the user as they expect that there are no closed stations listed, etc..

Additional information

I will provide a PR removing the text.

Mike McCready · Answer 1 · Mon Sep 05 2022 02:06:31 GMT+0800 (China Standard Time)

@Ein-Tim

Instead of a text implying that the data is very up-to-date, it would be more helpful to display a warning that the data may be inaccurate. Perhaps the text "Für die Richtigkeit der Teststellendaten sind die Testanbieter verantwortlich." from https://map.schnelltestportal.de/usage.html needs to be displayed more prominently?
According to https://map.schnelltestportal.de/impressum.html "T-Systems International GmbH" is responsible for the site. The changes proposed in #19 (comment) do not seem to have taken effect so far.

Tim · Answer 2 · Mon Sep 05 2022 02:10:31 GMT+0800 (China Standard Time)

@MikeMcC399

Instead of a text implying that the data is very up-to-date, it would be more helpful to display a warning that the data may be inaccurate. Perhaps the text "Für die Richtigkeit der Teststellendaten sind die Testanbieter verantwortlich." from map.schnelltestportal.de/usage.html needs to be displayed more prominently?

This seems like a very good idea! I will provide a PR replacing the text "Die hier gezeigten Schnelltestzentren werden täglich aktualisiert" with the text "Für die Richtigkeit der Teststellendaten sind die Testanbieter verantwortlich" tomorrow.

Mike McCready · Answer 3 · Mon Sep 05 2022 17:07:40 GMT+0800 (China Standard Time)

@Ein-Tim

See changes in eb93838

Tim · Answer 4 · Mon Sep 05 2022 17:11:04 GMT+0800 (China Standard Time)

@MikeMcC399 The commit you mentioned does not changed the text "Die hier gezeigten Schnelltestzentren werden täglich aktualisiert" if I'm not mistaken.

Tim · Answer 5 · Mon Sep 05 2022 17:14:46 GMT+0800 (China Standard Time)

PR #21 provided.

Mike McCready · Answer 6 · Mon Sep 05 2022 20:04:50 GMT+0800 (China Standard Time)

@Ein-Tim

Sorry for the uncommented reference to the new commit eb93838. What I meant was that you might like to wait until this change has gone into production so you can look at the effect and judge if changing the text as proposed is necessary.

It seems that there will be a warning if the data for a specific test station has not been updated for some time. This would be implementing the description from #19 (comment) that @dreske wrote about.

Tim · Answer 7 · Mon Sep 05 2022 20:20:25 GMT+0800 (China Standard Time)

@MikeMcC399

What I meant was that you might like to wait until this change has gone into production so you can look at the effect and judge if changing the text as proposed is necessary.

Ah, now I understand! The new change definitely looks good and will improve the situation drastically, but still I think the statement that testing stations are updated daily should be replaced or removed.

I'll leave my PR open and wait for feedback from @dreske.