corneliusmunz / legoino

Arduino Library for controlling Powered UP and Boost controllers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Hub emulation dependency on NimBLE???

AlbanT opened this issue · comments

commented

I installed the new 1.0.0 version of Legoino and while testing the HubEmulation example I got a compilation error on NimBLEDevice.h.
Maybe I missed a warning about dependencies but after I installed NimBLE-Arduino library it worked fine.
If it isn't in the documentation (I'm dyslexic so maybe I just missed it) I think it should be added :)

Hi @AlbanT ! Thanks for raising that issue. I have described it in the following section: https://github.com/corneliusmunz/legoino#remarks and in the Quickstart tutorial. Additionally i have marked it for the Library Manager as a dependent library and it should appear if you install Legoino that the dependent Library is needed.

But nevertheless. The hint about the dependency should appear at the beginning of the documentation and not at the end. So i will change this

I have improved the documentation and moved the information about the dependent library at the top of the README.md file. This is fixed with the following release: https://github.com/corneliusmunz/legoino/releases/tag/1.0.1