Giters

coreos / afterburn

A one-shot cloud provider agent

Home Page:https://coreos.github.io/afterburn/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

afterburn-sshkeys fails if no ssh key in metadata on ibmcloud

dustymabe opened this issue · comments

commented

Bug

If I don't pass an ssh key when starting an instance I get this error from afterburn:

[core@fcos-s390x-builder ~]$ journalctl -u afterburn-sshkeys@core.service 
Jun 01 01:06:40 fcos-s390x-builder systemd[1]: Starting afterburn-sshkeys@core.service - Afterburn (SSH Keys)...
Jun 01 01:06:40 fcos-s390x-builder afterburn[1371]: Error: failed to run
Jun 01 01:06:40 fcos-s390x-builder afterburn[1371]: Caused by:
Jun 01 01:06:40 fcos-s390x-builder afterburn[1371]:     0: writing ssh keys
Jun 01 01:06:40 fcos-s390x-builder afterburn[1371]:     1: no cloud-config section found in vendor-data
Jun 01 01:06:40 fcos-s390x-builder systemd[1]: afterburn-sshkeys@core.service: Main process exited, code=exited, status=1/FAILURE
Jun 01 01:06:40 fcos-s390x-builder systemd[1]: afterburn-sshkeys@core.service: Failed with result 'exit-code'.
Jun 01 01:06:40 fcos-s390x-builder systemd[1]: Failed to start afterburn-sshkeys@core.service - Afterburn (SSH Keys).

It should be fine if no ssh key was provided because the user could have provided it via Ignition.

cc @erlarese

Operating System Version

Fedora CoreOS 36.20220511.dev.0 on s390x in IBM Cloud

Afterburn Version

afterburn-5.3.0-1.fc36.s390x

Environment

s390x instance in IBMCloud

Expected Behavior

no failure

Actual Behavior

failure

commented

Can confirm this looks good now:

[core@coreos-s390x-builder ~]$ systemctl status afterburn-sshkeys@core.service
● afterburn-sshkeys@core.service - Afterburn (SSH Keys)
     Loaded: loaded (/usr/lib/systemd/system/afterburn-sshkeys@.service; enabled; preset: enabled)
     Active: active (exited) since Mon 2023-02-06 20:45:39 UTC; 1min 2s ago
    Process: 936 ExecStart=/usr/bin/afterburn ${AFTERBURN_OPT_PROVIDER} --ssh-keys=core (code=exited, status=0/SUCCESS)
   Main PID: 936 (code=exited, status=0/SUCCESS)
        CPU: 4ms

Feb 06 20:45:39 coreos-s390x-builder systemd[1]: Starting afterburn-sshkeys@core.service - Afterburn (SSH Keys)...
Feb 06 20:45:39 coreos-s390x-builder systemd[1]: Finished afterburn-sshkeys@core.service - Afterburn (SSH Keys).
[core@coreos-s390x-builder ~]$ 
[core@coreos-s390x-builder ~]$ rpm -q afterburn
afterburn-5.4.0-1.fc37.s390x