Giters

coopdevs / odoo-role

Ansible role provisioning Odoo.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Should we check if the virtualenv already exists?

enricostano opened this issue · comments

commented

Right now we check if the virtualenv is already existent: https://github.com/coopdevs/odoo-role/blob/master/tasks/virtualenv.yml#L26

Is this really needed? What happens if we create a new virtualenv in a path where there is already one?

I ask so since I found myself running the latest version of this role that switches from Python 2.7 to 3 and the current check didn't allow me to create the (already existent but 2.7 virtualenv).

I had to rm -rf /opt/.odoo_venv and run the provision playbook again to get it working. What are the risks of doing this on a production machine?

commented

@cesarlr @danypr92 I'm closing this one since it was an edge case switching from a Python version to another.

Feel free to open it again if you think this is still an issue.