Implement or document dataIdFromObject

Question

Implement or document dataIdFromObject

cmbirk opened this issue 5 years ago · comments

It would be useful for apollo-cache-hermes to allow a different cache key other than id on a given object. In-memory-cache uses dataIdFromObject that can be read about in their normalization documentation here: https://www.apollographql.com/docs/react/advanced/caching/#normalization

We have used that function to determine different cache keys by __typename.

👋 I would be willing to help implement this feature or document it if it currently exists, but will need some guidance from your team.

I didn't see this on your roadmap, but is this something you would be willing to add?

Ian MacLeod · Answer 1 · Thu Jul 04 2019 02:08:34 GMT+0800 (China Standard Time)

You're in luck! It's something we support today 💪. You can customize the id behavior by passing the entityIdForNode configuration option when instantiating the cache

Chris Birk · Answer 2 · Thu Jul 04 2019 06:53:08 GMT+0800 (China Standard Time)

Perfect, thanks! I'll open a PR to update the readme with instructions.

Ian MacLeod · Answer 3 · Thu Jul 04 2019 07:32:49 GMT+0800 (China Standard Time)

Fantastic! Thanks as well

…

On Wed, Jul 3, 2019, 15:53 Chris Birk ***@***.***> wrote: Perfect, thanks! I'll open a PR to update the readme with instructions. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#418?email_source=notifications&email_token=AAAKDHKO2N5HAJYFFL4QUYTP5UUVJA5CNFSM4H5HVCJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZF36YA#issuecomment-508280672>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAKDHOTDAUK6HOTAJFJPILP5UUVJANCNFSM4H5HVCJA> .

Wout Mertens · Answer 4 · Tue Jul 23 2019 00:00:29 GMT+0800 (China Standard Time)

why not support dataIdFromObject so conversion from inmemory is without changes? Isn't it just an alias?