Compability with php 7.2

Question

Compability with php 7.2

hajek-raven opened this issue 6 years ago · comments

Filip Hájek commented 6 years ago

Jan Trejbal · Answer 1 · Tue Mar 13 2018 19:44:44 GMT+0800 (China Standard Time)

Hi, can you submit more info?

We already use it on PHP 7.2

Filip Hájek · Answer 2 · Tue Mar 13 2018 19:59:23 GMT+0800 (China Standard Time)

There are some incompabilities in Payment and ReturnedPayment.
For example:
public function setReturnUrl(string $returnUrl, array $params = []) : void
in Trejjam\ThePay\Payment is not compatible with parent class (has more parameters).

Jan Trejbal · Answer 3 · Tue Mar 13 2018 22:35:17 GMT+0800 (China Standard Time)

Yes, it has more parameters. But it is not incompatibility on language or parent library level.

This library in master has minimal PHP version 7.1, you can view a valid response here: https://3v4l.org/uD31C

This library is an extension for Nette so this parameter extending allow construct URL in framework way, but it should allow passing valid URL to parent class as well.
If you think this is not true, feel free to pass some failing examples.