Release new version supporting nette/forms 3.1.8

Question

Release new version supporting nette/forms 3.1.8

foxycode opened this issue 2 years ago · comments

Tomáš Jacík commented 2 years ago

I see support for nette/forms version 3.1.8 is already merged to master. Can you please release new version?

Also, is there still need to limit this package to specific version? Wouldn't be ~3.1.7 better?

Milan Felix Šulc · Answer 1 · Tue Dec 13 2022 22:58:37 GMT+0800 (China Standard Time)

~3.1.7 sounds good to me, please prepare PR.

Tomáš Jacík · Answer 2 · Wed Dec 14 2022 00:53:33 GMT+0800 (China Standard Time)

@f3l1x I thought I have access, can you please allow me push new branches?

Dalibor Korpar · Answer 3 · Wed Dec 14 2022 23:08:04 GMT+0800 (China Standard Time)

No, please don't do that. This library heavily uses some internal code from nette/forms and because of that it's allways strict on using exact minor version. Having in composer ~ for nette forms is highly dangerous since it could potentially crash current release. @foxycode @f3l1x

Dalibor Korpar · Answer 4 · Wed Dec 14 2022 23:15:17 GMT+0800 (China Standard Time)

0.5.4 released. I wanted to add build for 8.2 before that and made support for it, but you're rushing into it. You can allways just put ^0.6 in your composer and you'll be on master if it's critical.

Tomáš Jacík · Answer 5 · Wed Dec 14 2022 23:54:34 GMT+0800 (China Standard Time)

@dakorpar Can you please tell which internal things? Maybe I can speak with David Grudl to fix these things in nette/forms

Dalibor Korpar · Answer 6 · Thu Dec 15 2022 17:31:11 GMT+0800 (China Standard Time)

There's noting to fix, library itself is using some methods that are marked as @internal those methods can be changed at any minor version, because of nature of this library it's actually built on top of nette/forms and doing some changes on it, it is very dangerous not to have it like that and in the end there's really no need for this.