contributte / datagrid

:muscle: DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc

Home Page:https://contributte.org/packages/contributte/datagrid/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong display of toolbar & export buttons

elring opened this issue · comments

After commit 55fd8b4 the toolbar look wrong:

image

  1. The buttons are without any space between - this is because of now wrong CSS selector in datagrid.css - extra div is now needed - line 74 should be changed to:
.datagrid .datagrid-toolbar > div > span > a {
  margin-left: 0.5em;
}

  1. The export buttons are on new line - this is because of the new snippet div - the export toolbar is outside of it. This can be solved either by moving the export toolbar into the new snippet or by css "hack" of the snippet div:
.datagrid .datagrid-toolbar > div {
  display: inline-block;
}

After these changes, toolbar looks better:

image

Should I make PR (which way for 2)?

  1. Yes, pls create a new MR, thanks! 👍
  2. I am not sure I follow - what do you mean by which way for 2?
  1. Here you are :)
  2. I chose not to modify template and stick with CSS changes (the question was about this - move span snippet exports in template or create new CSS rule).

Thx 👍