Wrong display of toolbar & export buttons
elring opened this issue · comments
Elring commented
After commit 55fd8b4 the toolbar look wrong:
- The buttons are without any space between - this is because of now wrong CSS selector in datagrid.css - extra div is now needed - line 74 should be changed to:
.datagrid .datagrid-toolbar > div > span > a {
margin-left: 0.5em;
}
- The export buttons are on new line - this is because of the new snippet div - the export toolbar is outside of it. This can be solved either by moving the export toolbar into the new snippet or by css "hack" of the snippet div:
.datagrid .datagrid-toolbar > div {
display: inline-block;
}
After these changes, toolbar looks better:
Should I make PR (which way for 2)?
Pavel Janda commented
- Yes, pls create a new MR, thanks! 👍
- I am not sure I follow - what do you mean by which way for 2?
Elring commented
- Here you are :)
- I chose not to modify template and stick with CSS changes (the question was about this - move span snippet exports in template or create new CSS rule).
Pavel Janda commented
Thx 👍