contentful / forma-36

A design system by Contentful

Home Page:https://f36.contentful.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

πŸ› Bug - Missing peerDependency warnings when installing packages using Yarn (modern)

wojtekmaj opened this issue Β· comments

Forma 36 bug report

Summary

When installing packages using Yarn (modern), missing peerDependency warnings appear:

➀ YN0000: β”Œ Resolution step
➀ YN0002: β”‚ @contentful/f36-icon@npm:4.52.1 [ed127] doesn't provide react-dom (p6a8ed), requested by @contentful/f36-core
➀ YN0002: β”‚ @contentful/f36-list@npm:4.52.1 [ed127] doesn't provide react-dom (p8a8f4), requested by @contentful/f36-core
➀ YN0002: β”‚ @contentful/f36-pagination@npm:4.52.1 [ed127] doesn't provide react-dom (pe4e8c), requested by @contentful/f36-core
➀ YN0002: β”‚ @contentful/f36-pagination@npm:4.52.1 [ed127] doesn't provide react-dom (p06033), requested by @contentful/f36-icons
➀ YN0002: β”‚ @contentful/f36-pagination@npm:4.52.1 [ed127] doesn't provide react-dom (p4d246), requested by @contentful/f36-button
➀ YN0002: β”‚ @contentful/f36-pagination@npm:4.52.1 [ed127] doesn't provide react-dom (pe02da), requested by @contentful/f36-forms
➀ YN0002: β”‚ @contentful/f36-popover@npm:4.52.1 [ed127] doesn't provide react-dom (pde16a), requested by @contentful/f36-core
➀ YN0002: β”‚ @contentful/f36-popover@npm:4.52.1 [ed127] doesn't provide react-dom (p0c8f9), requested by react-popper
➀ YN0002: β”‚ @contentful/f36-spinner@npm:4.52.1 [ed127] doesn't provide react-dom (pff6e4), requested by @contentful/f36-core
➀ YN0002: β”‚ @contentful/f36-text-link@npm:4.52.1 [ed127] doesn't provide react-dom (p4d749), requested by @contentful/f36-core
➀ YN0002: β”‚ @contentful/f36-typography@npm:4.52.1 [ed127] doesn't provide react-dom (p0aaa4), requested by @contentful/f36-core

This signifies a problem that results in packages not working at all in Yarn PnP mode, and prone errors in others.

Environment

n/a

Steps to reproduce

yarn init -2
yarn add @contentful/f36-icon

Expected results

No warnings

Actual results

Warnings (see above)

Can confirm #2587 fixed the issue and we no longer need packageExtensions Yarn setting to fix the warnings.