containers / youki

A container runtime written in Rust

Home Page:https://containers.github.io/youki/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

change `mount.rs` find_parent_mount from pub to private

lengrongfu opened this issue · comments

The current find_parent_mount method is only in impl Mount use, we can change to private fn from pub fn.

pub fn find_parent_mount(

Note that this change would likely be a breaking change, so PR should be labeled accordingly, along with changelog info.

@Mossaka Do you use this function in runwasi?

No, it's not used in runwasi. However, I would be more careful in making breaking changes if we don't have a strong motivation.

Thanks every body suggestion, we can hold this issue, keep watch, and then decide how to resolve.