Journald logging name/tag now mutually exclusive

Question

Journald logging name/tag now mutually exclusive

strideynet opened this issue 2 years ago · comments

Hi !

I spotted something which looks like a regression in the behaviour of journald logging between releases v2.0.30 and v2.0.31

5d5b853

This commit appears to change the behaviour unexpectedly. Prior to this commit, if a tag was specified, both CONTAINER_TAG and CONTAINER_NAME would be present, but now, when a tag is specified, only CONTAINER_TAG will be present. If this was intentional, could the reasoning please be explained ?

Daniel J Walsh · Answer 1 · Wed Apr 13 2022 01:38:20 GMT+0800 (China Standard Time)

@giuseppe PTAL

Giuseppe Scrivano · Answer 2 · Thu Apr 14 2022 15:48:58 GMT+0800 (China Standard Time)

that is intentional. More details are in the discussion here: #301

Noah Stride · Answer 3 · Thu Apr 14 2022 17:57:47 GMT+0800 (China Standard Time)

I am unable to find anything in #301 that explains why CONTAINER_NAME should be dropped when CONTAINER_TAG is provided.

Peter Hunt · Answer 4 · Fri Apr 15 2022 01:19:36 GMT+0800 (China Standard Time)

hmm I can't see any reason why we wouldn't print both tag and name if they're both present: #333

Giuseppe Scrivano · Answer 5 · Fri Apr 15 2022 17:24:02 GMT+0800 (China Standard Time)

closed by #333

Daniel J Walsh · Answer 6 · Fri Apr 15 2022 18:05:09 GMT+0800 (China Standard Time)

This means we need a new release of conmon. @haircommander