Unable to run conmon test on Fedora
tedyu opened this issue · comments
Zhihong Yu commented
I use Fedora.
Under conmon local repo (as of commit 89b2478), I ran:
$ make test
go test -tags "" github.com/containers/conmon/runner/conmon_test/
Running Suite: Conmon Suite
...
conmon
/home/zyu/go-workspace/src/github.com/containers/conmon/runner/conmon_test/conmon_test.go:36
ctr logs
/home/zyu/go-workspace/src/github.com/containers/conmon/runner/conmon_test/conmon_test.go:83
log driver as journald should pass [It]
/home/zyu/go-workspace/src/github.com/containers/conmon/runner/conmon_test/conmon_test.go:117
Expected
<string>: [conmon:e] Include journald in compilation path to log to systemd journal
to be empty
Zhihong Yu commented
/cc @giuseppe
Peter Hunt commented
to pass this you'll need to download systemd-devel. Though that's actually a problem with the test (it shouldn't fail if conmon wasn't compiled without systemd-devel)
Zhihong Yu commented
Package systemd-devel-243.7-1.fc31.x86_64 is already installed.
Dependencies resolved.
Nothing to do.
Peter Hunt commented
interesting. what's the output of
pkg-config --libs libsystemd
Zhihong Yu commented
pkg-config --libs libsystemd
-lsystemd
Peter Hunt commented
what's the output of make
?
Zhihong Yu commented
mkdir -p bin
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/conmon.o -c src/conmon.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/cmsg.o -c src/cmsg.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/ctr_logging.o -c src/ctr_logging.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/utils.o -c src/utils.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/cli.o -c src/cli.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/globals.o -c src/globals.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/cgroup.o -c src/cgroup.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/conn_sock.o -c src/conn_sock.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/oom.o -c src/oom.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/ctrl.o -c src/ctrl.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/ctr_stdio.o -c src/ctr_stdio.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/parent_pipe_fd.o -c src/parent_pipe_fd.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/ctr_exit.o -c src/ctr_exit.c
cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DVERSION=\"2.0.15-dev\" -DGIT_COMMIT=\""89b2478b507c6f285cd97ae8e55c85b9cafe6e81"\" -D USE_JOURNALD=0 -o src/runtime_args.o -c src/runtime_args.c
cc -o bin/conmon src/conmon.o src/cmsg.o src/ctr_logging.o src/utils.o src/cli.o src/globals.o src/cgroup.o src/conn_sock.o src/oom.o src/ctrl.o src/ctr_stdio.o src/parent_pipe_fd.o src/ctr_exit.o src/runtime_args.o -lglib-2.0 -lsystemd
I tried 'make test' again and got same error as last week.
Peter Hunt commented
try
rm /usr/bin/conmon && make install PREFIX=/usr
Zhihong Yu commented
Tests pass now