containers / conmon-rs

An OCI container runtime monitor written in Rust

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Enable prow for this repository

saschagrunert opened this issue · comments

We should consider to use the OpenShift prow instance for this repository to handle our whole development workflow.

@rhatdan @edsantiago do you know how we could enable prow for this repo?

I think we just need to add configs to github.com/openshit/release. Do you want the review functionality or do you also want tests?

Just the review and approval handling, ah yeah I found it let me draft a PR.

one limitation of using gh actions with prow is prow isn't gh action aware so we'd have to do the /hold /lgtm dance. We don't run into it in cri-o because e2e tests take way longer than gh actions tests

one limitation of using gh actions with prow is prow isn't gh action aware so we'd have to do the /hold /lgtm dance. We don't run into it in cri-o because e2e tests take way longer than gh actions tests

Prow can at least know that every context has to be successful before doing a merge.