containers / common

Location for shared common files in github.com/containers repos.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Leaks of `c/image/types.Image` = persistent HTTP connections

mtrmac opened this issue · comments

From a quick code grep, it seems to me that

remoteImg, err := remoteRef.NewImage(ctx, sys)
(and, pedantically,
if _, err := ref.NewImage(context.Background(), nil); err != nil {
, though that one is a no-op) should .Close() the returned types.Image.

That’s nowadays necessary to close potentially-persistent HTTP connections for c/image/docker .