restricting main branch to "[ ] Require pull request before merging" is being reverted
cgwalters opened this issue · comments
I want to make reviews required by default on this project (as they should be on most).
I can make the change successfully in the web UI, but it seems like something is reverting it later. Is there some automation on the containers/ GH org that is doing something like this?
I am not aware of anything being set. If it is, it is likely an accident.
I too am unaware, didn't even know overriding it at the org-level was possible (is it?).
Just looked through all the org-level settings and didn't find anything that would change settings like that. Hmmm. We do have 10-something apps setup on the org., it's entirely possible one is responsible but none jump out at me. I'll take the list to the team and see which ones we can disable/remove.
Thanks Chris. Whatever is reverting it seems to be running on a roughly daily schedule. The setting lasted for hours at least last time I tried it.
Semi-blindly trying openshift/release#36102
@baude not urgent but openshift/release#36102 (comment) when you get a chance
@cevich is it the case today that all the other repositories in the containers org that have Prow jobs also use Prow to merge (i.e. with approve/lgtm + tide)?
Unfortunately no, not all 100-some odd repos, Red Hat doesn't maintain all of them. Off-hand, it's about 15-20 repos that use Prow.
@cgwalters, did you resolve the issue in the meantime?
Yes, we dropped Prow for now