Defaults for `name` and `disableCheck` in configuration files

Question

Defaults for `name` and `disableCheck` in configuration files

dilyanpalauzov opened this issue 2 years ago · comments

https://www.cni.dev/docs/spec/#configuration-format describes the /etc/cni/net.d/ configuration files.

Please write down, whether the "name" parameter is mandatory and what happens, if it is optional and missing. https://github.com/cri-o/cri-o/blob/main/contrib/cni/99-loopback.conf is an example without "name":.

The default value for disableCheck is not documented.

Zhou Zhiqiang · Answer 1 · Wed Oct 05 2022 12:14:31 GMT+0800 (China Standard Time)

I am also bothered with this issue recently.

minikube does not works with that 200-loopback.conf because the field name is missed.

Dan Williams · Answer 2 · Mon Oct 17 2022 23:48:31 GMT+0800 (China Standard Time)

See #536 ... SPEC has indicated that 'name' is mandatory since 2015 (because it's not marked as optional) but it wasn't consistently enforced until that PR in from 2018.

But also: cri-o/cri-o#6318

Dan Williams · Answer 3 · Tue Oct 18 2022 00:12:39 GMT+0800 (China Standard Time)

Turns out there's already cri-o/cri-o#6273

Дилян Палаузов · Answer 4 · Tue Oct 18 2022 00:22:39 GMT+0800 (China Standard Time)

My reading of cri-o/cri-o#6273 is that currently running a configuration file without a "name": does not create any problems. (Since nobody reports problems, when the loopback plugin has not "name":).