consuldemocracy / consuldemocracy

Consul Democracy - Open Government and E-Participation Web Software

Home Page:https://consuldemocracy.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Budget Investments displaying as Winning Investments when Display Results is unchecked

coslajohn opened this issue · comments

Why is this Needed?

comment: # In a PB when display results is unchecked an Investment is still displayed as a Winning Investment. This can cause some confusion if there has been a manual adjustment to the results. Sometimes we do part funding of the lowest scoring investments or may need to make manual adjustments (but don't want to mark a project as Incompatible etc)
What we do in those circumstances is publish results using a custom page, but the current behaviour can lead to Investments displaying a Winner badge when they are not a winner and vice versa

Description

Type: Bug

Current Behavior

comment: # In a PB when display results is unchecked an Investment is still displayed as a Winning Investment

image

image

Expected Behavior

comment: # The Winning Investment Project Badge should not be displayed if Show Results is not ticked

Steps to reproduce

comment: # Calculate Winners, untick Show Results, view investment project

Definition of Done

comment: # It may be worth considering whether or not marking a project as a winner would be a useful addition to the Valuation page?