SlevomatCodingStandard.ControlStructures.YodaComparison is removed

Question

SlevomatCodingStandard.ControlStructures.YodaComparison is removed

oojacoboo opened this issue 6 years ago · comments

The ruleset SlevomatCodingStandard.ControlStructures.YodaComparison has been removed. Please update the ruleset as this breaks phpcs, at least within the vscode plugin currently.

It appears this sniff has been updated to DisallowYodaComparisonSniff.

Vašek Purchart · Answer 1 · Mon Jun 25 2018 15:44:55 GMT+0800 (China Standard Time)

Yes, this was already addressed long time ago: 2bafec2.

But I am not sure if your phpcs setup is correct, since as you can see, due to the version constraints you should have never been able to install Slevomat CS 4.0 alongside an incompatible version of Consistence CS.

Jacob Thomason · Answer 2 · Wed Jun 27 2018 06:13:10 GMT+0800 (China Standard Time)

I have the following in my composer.json

"slevomat/coding-standard": "~4.6",
"consistence/coding-standard": "~3.4",

Vašek Purchart · Answer 3 · Wed Jun 27 2018 15:21:19 GMT+0800 (China Standard Time)

That is pretty weird, are you sure, there is no other CS ruleset, where an old version of Yoda sniff might be included? Can you verify that the Consistence's ruleset contains the changed rule on your disk? (should be at vendor/consistence/coding-standard/Consistence/ruleset.xml).

And how do you run your phpcs (which cmd args)?

Jacob Thomason · Answer 4 · Fri Jul 06 2018 23:44:30 GMT+0800 (China Standard Time)

Looks like the issue was within some other repos within my IDE project. So, after composer updating each repo, the ruleset disappeared. Sorry for the false alarm.