conradoqg / naivecoin

Once again great work.
I would want to change the transaction fee destination from the miner's address to the receiver's address. Please how do i go about that.

Hey!

When you mine a new block you can inform the reward address. So the miner is who decides which address should receive the reward.

Best

Transaction fees can just be put to zero.

EDIT: Response to your response below.
@conradoqg I think we both mis-understood. I was saying just do not have a fee, therefore there is no fee, causing the same result (the whole transaction going to the receiver's address). I am not having any issues with this code, actually quite enjoying it. Added all kinds of toys to it.

What I want to do is to give the transaction fee to the address at the output ( amount receiver ) instead of the miner address.

…

On Jan 6, 2018 7:58 PM, "Marc Godard" ***@***.***> wrote: Transaction fees can just be put to zero. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATuQJ8CeXBa8pP4PKOefKKV5lLFm9qWtks5tH9BsgaJpZM4RVSJC> .

@Andrewsopoku
Hey, I added the property feeAddress (as optional) to the mine endpoint, commit 088a6bb.

@MarcGodard Could you give me more details about how is that happening and where? Thanks!

Great. The only issue is from the httpserver, I wouldn't know the output address ( the address receiving the transaction amount ). I am thinking of changing lib/miner/index.js line 57. But how to get the transaction output address from that point is the problem.

…

On Jan 6, 2018 10:10 PM, "Conrado Quilles Gomes" ***@***.***> wrote: @Andrewsopoku <https://github.com/andrewsopoku> Hey, I added the property feeAddress (as optional) to the mine endpoint, commit 088a6bb <088a6bb> . @MarcGodard <https://github.com/marcgodard> Could you give me more details about how is that happening and where? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATuQJzbPVsJqIUXoPBW2rSvPZfZjwhOeks5tH-9NgaJpZM4RVSJC> .

I think I'm not getting your goal. Is this the line you are talking about?

naivecoin/lib/miner/index.js

Line 57 in 088a6bb

let rejectedTransactions = 0;

Usually, the miner has his own address because he is the one spending time and energy to mine the block.

I was referring to this line. https://github.com/conradoqg/naivecoin/blob/088a6bbb9d328b88a75124567e392d0c9cb89b87/lib/miner/index.js#L102 I am looking at the miner address getting the reward as usual for the work it does. Some People usually don't go into crytocurrencies because they find it difficulty getting their Fiat currency back should they decide to change their crytocurrencies into a Fiat currency ( Dollars). To motivate People to readily receive crytocurrency and pay the sender equivalent amount in Fiat currency, I thought of giving the receiver the transaction fee instead of giving it to the miner. Please I hope you get me.

…

On Jan 6, 2018 11:01 PM, "Conrado Quilles Gomes" ***@***.***> wrote: I think I'm not getting your goal. Is this the line you are talking about? https://github.com/conradoqg/naivecoin/blob/088a6bbb9d328b88a75124567e392d 0c9cb89b87/lib/miner/index.js#L57 Usually, the miner has his own address because he is the one spending time and energy to mine the block. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATuQJ_WGzSRTgajgPJqNkc9dP2CKRhSYks5tH_sUgaJpZM4RVSJC> .

I see now. I think you would need to change a couple of things:

The miner selects the transactions that it wants to mine, so you could create a list of output transactions addresses and split the fee value by all output addresses (proportionally or not). You may want to remove the change transaction (the money that the sender receives back as a change).
You will need to change the transaction check to enable multiple fee transactions (eg 1 for each output transaction)

Anyway, it's possible to do that and I think you have all information you need. If you want more information tell me that I can give you some source references.

Best

Hi Conrad, do you believe that this code is ready for production ?

Hey. No, I don't believe it's ready for production. Check the // INFO comments, most of them should be implemented before putting something like naivechain to production IMO.

Transaction fee destination