connor4312 / cockatiel

🐦 A resilience and transient-fault-handling library that allows developers to express policies such as Backoff, Retry, Circuit Breaker, Timeout, Bulkhead Isolation, and Fallback. Inspired by .NET Polly.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The first delay of DelegateBackoff and ExponentialBackoff is always zero.

yowu opened this issue · comments

Let's take look at an example

 // use a ConstantBackoff
 const constDelayRetry = Policy.handleAll()
    .retry()
    .attempts(3)
    .backoff(new ConstantBackoff(10, 3));

  constDelayRetry.onRetry(({ delay }) => console.log('delay for next call: ', delay));
  await constDelayRetry.execute(() => {
    throw new Error('exception');
  });

// use a DelegateBackoff
  const delegatedDelayPolicy = Policy.handleAll()
    .retry()
    .attempts(3)
    .backoff(new DelegateBackoff(() => 10));

  delegatedDelayPolicy.onRetry(({ delay }) => console.log('delay for next call: ', delay));
  await delegatedDelayPolicy.execute(() => {
    throw new Error('exception');
  });

The output looks like

delay for next call:  10
delay for next call:  10
delay for next call:  10
delay for next call:  0
delay for next call:  10
delay for next call:  10

Conceptually, I would expect all delays are 10, but unfortunately, the first delay of DelegateBackoff is always 0.
Looks like the ExponentialBackoff has the same problem.

But Polly doesn't has such problem.
It looks like RetryPolicy.execute should adjust the logic to backoff.next() first then do the delay.

Thanks for the issue, I would be happy to take a PR, otherwise I can fix this in a couple days.

Fixed in the linked PR