composablesys / collabs

Collabs library monorepo

Home Page:https://collabs.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CBoolean load/save not required

mweidner037 opened this issue · comments

In ToggleCBoolean, commenting out load and save does not cause an error, even though they should be abstract in the superclass. This is probably some unfortunate interaction between mixins and the fact that CBoolean extends Collab.

We should check the other mixins for similar errors.

One idea: replace AbstractCBoolean class with interface; replace CBoolean with ICBoolean, then set CBoolean = ICBoolean & Crdt (extra benefit of making interface clearer).

I've removed the mixins from TypeScript's view and instead just type the resulting classes explicitly.