components / jqueryui

Shim repository for jQuery UI.

Home Page:http://jqueryui.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

component.js locks jquery dependency to >= 1.8

benschwarz opened this issue · comments

… Which means that bower (and perhaps component.js) will use jquery 2.x.x has the dependency, which is probably pretty unfavourable for most people.

commented

PR welcomed

Wait, you want the pr, right? Closed prematurely?
Should I lock to ~> 1.8?

Happy to do it, but you need to meet me half way with where you want to take it

commented

I'm sure for the PR. I think you should lock to ~1.9
and I'll merge it

Ok. Will do. 

Sent from Mailbox for iPhone

On Fri, Jun 28, 2013 at 6:30 PM, Nami-Doc notifications@github.com
wrote:

I'm sure for the PR. I think you should lock to ~1.9

and I'll merge it

Reply to this email directly or view it on GitHub:
#14 (comment)

FYI, by closing this early you set a bit of a negative tone and also made it harder to contribute — I was only trying to help.

commented

Two things :

  • I use github's issue tracker, so I try to get things closed to have a priority list
  • I'm on my phone right now, so I don't write a lot.
    So I close quite early. I shoud've answered differentlt, however.

@Nami-Doc gimme a hug, ya big lug.

commented

/weekendhug

🍰