components / bootstrap

Shim repository for Twitter Bootstrap.

Home Page:http://getbootstrap.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

enable for use with jquery 2.0.3

mazhack opened this issue · comments

please fix it....

$ php -q composer.phar update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Conclusion: remove components/jquery 2.0.3
- Conclusion: don't install components/jquery 2.0.3
- Installation request for components/bootstrap 3.* -> satisfiable by components/bootstrap[3.0.0].
- Conclusion: don't install components/jquery 2.0.2
- Conclusion: don't install components/jquery 2.0.1
- components/bootstrap 3.0.0 requires components/jquery 1.9.* -> satisfiable by components/jquery[1.9.0, 1.9.1].
- Can only install one of: components/jquery[2.0.0, 1.9.0].
- Can only install one of: components/jquery[2.0.0, 1.9.1].
- Installation request for components/jquery 2.0.* -> satisfiable by components/jquery[2.0.0, 2.0.1, 2.0.2, 2.0.3].

I believe it should just be "components/jquery": "*", since I believe it should be compatible with both. Correct me if I'm wrong!

i install too jquery-ui without problem, maybe with "components/jquery": ">=1.9", jquery 2 remove old ie support and bootstrap work fine.

I also need this fixed.
It looks like composer.json was updated:

"components/jquery": "*"

  • "components/jquery": "1.9.*"

changing this back would fix the issue.

* is almost never what you want. I don't know if it is reasonable to assume that any future version of jquery will work w/ bootstrap but if it is known that 2.* should work, we could maybe change this to something like:

"components/jquery": ">=1.9.1,<3.0"

That should be more correct and safer than * while being less restrictive than ~1.9.1.

My change to the composer.json worked for all valid versions of jQuery. Please confirm and I can merge it in today.