comonicon / Comonicon.jl

Your best CLI generator in JuliaLang

Home Page:https://comonicon.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build Fails on Windows 11 (dev ring 22543) even though tests complete sucessfully [BUG]

ACastanza opened this issue · comments

Describe the bug
Building GSEA.jl on Windows 11: https://github.com/KwatMDPhD/GSEA.jl/ fails with

[ Info: PackageCompiler: Done
✔ [04m:04s] PackageCompiler: compiling incremental system image
[ Info: creating path: D:\Documents\GitHub\GSEA.jl\build\gsea\completions
ERROR: LoadError: unsupported OS, please open an issue to request support at https://github.com/comonicon/Comonicon.jl
Stacktrace:
  [1] error(s::String)
    @ Base .\error.jl:33
  [2] osname()
    @ Comonicon.Builder C:\Users\acast.julia\packages\Comonicon\ryWxf\src\builder\tarball.jl:11
  [3] tarball_name(m::Module, name::String, postfix::String)
    @ Comonicon.Builder C:\Users\acast.julia\packages\Comonicon\ryWxf\src\builder\tarball.jl:2
  [4] build_application_tarball(m::Module, options::Comonicon.Configs.Comonicon)
    @ Comonicon.Builder C:\Users\acast.julia\packages\Comonicon\ryWxf\src\builder\app.jl:66
  [5] command_main(m::Module, options::Comonicon.Configs.Comonicon)
    @ Comonicon.Builder C:\Users\acast.julia\packages\Comonicon\ryWxf\src\builder\cli.jl:76
  [6] #command_main#1
    @ C:\Users\acast.julia\packages\Comonicon\ryWxf\src\builder\cli.jl:49 [inlined]
  [7] command_main
    @ C:\Users\acast.julia\packages\Comonicon\ryWxf\src\builder\cli.jl:48 [inlined]
  [8] #comonicon_install#13
    @ C:\Users\acast.julia\packages\Comonicon\ryWxf\src\frontend\cast.jl:424 [inlined]
  [9] comonicon_install()
    @ GSEA C:\Users\acast.julia\packages\Comonicon\ryWxf\src\frontend\cast.jl:424
 [10] top-level scope
    @ D:\Documents\GitHub\GSEA.jl\deps\build.jl:3
in expression starting at D:\Documents\GitHub\GSEA.jl\deps\build.jl:3

Version of the package:
Project GSEA v0.3.1
Status D:\Documents\GitHub\GSEA.jl\Project.toml
[863f3e99] Comonicon v0.12.6
[a93c6f00] DataFrames v1.3.2
[1fe83854] OnePiece v0.5.3 https://github.com/KwatMDPhD/OnePiece.jl#main
[2913bbd2] StatsBase v0.33.14
[9a3f8284] Random

To Reproduce
https://github.com/KwatMDPhD/GSEA.jl/ on Step #2 Transferable Binary
(julia --project deps/build.jl app tarball)

Expected behavior
A successful package build.

@KwatMDPhD

Hi Windows is not supported by this package yet, as I don't have much knowledge on packing things on Windows. If someone wants to help on this that would be nice

e.g I'm not sure if tarball is the correct format on windows, perhaps one should pack things into a .exe file instead? I never see anything that is packed as tarball for Windows

I can take this on. @Roger-luo , any advice on which file and how to do this?

https://julialang.github.io/PackageCompiler.jl/dev/search.html?q=windows has some information too.

Yeah first thing is to figure out how to pack things generated by PackageCompiler on windows. I think juliaup used to be packing binaries on windows. Perhaps @davidanthoff knows more details about this workflow but I guess he is also quite busy.

For the specific file you can look at the the build_application_tarball function to see if it be extended for windows