Please create a .jar file, including your license, for distribution
JoePfeiffer opened this issue · comments
Is your feature request related to a problem? Please describe.
OpenRocket (https://github.com/openrocket/openrocket) has begun using your library, and we would like to properly cite your license. At the moment we're just linking to the license here on your project page; we'd also like to link to a copy embedded in your .jar
Describe the solution you'd like
As in the title: we'd very much appreciate if you could distribute a .jar with your license file, preferably at the top level.
Describe alternatives you've considered
We spent a little while trying to add it in ourselves, but eventually concluded simply having your library distributed with this would be of benefit both to us and to your other users.
Additional context
Add any other context about the feature request here.
OpenRocket (https://github.com/openrocket/openrocket) has begun using your library
Cool project!
Yeah I agree that would be nice, just need to figure out the correct maven magic to do that. Help would be appreciated.
Yeah I agree that would be nice, just need to figure out the correct maven magic to do that. Help would be appreciated.
I wish I could! I know exactly 0 about maven.
Oh it might just be creating a LICENSE.txt file in src/main/resources/META-INF (of every module), see https://stackoverflow.com/a/38836843. I'll try that.
See PR: #253
Ok, released 0.18.2 with the fix for this: https://github.com/commonmark/commonmark-java/blob/main/CHANGELOG.md#0182---2022-02-24
It should show up on Maven Central shortly.
Thank you!