rename/alias dockerImageId to dockerImageName
qwofford opened this issue · comments
A Docker Image ID refers to the MD5 checksum of a complete docker image. If the CWL spec includes "dockerFile" and "dockerImageId" at the same time, this results in a logical conflict.
The dockerImageId is an Md5 which corresponds with a particular container manifest, ref: https://docs.docker.com/engine/reference/commandline/images/
So it's not possible to set a dockerImageId without first having built the dockerFile specified. It seems that introducing a dockerImageName and dockerImageTag to the CWL spec would solve this problem.
See the following discussion for related discussion:
https://cwl.discourse.group/t/dockerimageid-can-not-be-known-before-dockerfile-build/223
To be clear here, in CWL dockerImageId is a name, not the container image checksum. I agree this is confusing and that a new alias for this concept should be added in CWL v1.3; a deprecation notice added; and removing dockerImageId in a future CWL version