Giters

commitdev / zero-aws-eks-stack

zero module for a basic AWS kubernetes stack on EKS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update teardown section in README and Makefile

aspcanada opened this issue · comments

commented

There are a few discrepancies in the Makefile and the README with respect to tearing down an environment.

  1. teardown-secrets removes the ci-user secret key which is shared b/t envs.
  2. teardown-secrets also removed the -eks-cluster-creator role which is also shared b/t envs.
  3. teardown should accept an environment param and should skip "shared" teardown steps.

Should have a teardown-shared-secrets and teardown-shared-roles make commands.

commented

Yeah that's true, we should probably add a note before tearing down shared resources that you should repeat the previous steps for any other environments, and like you mentioned, split teardown-secrets into two targets, one for env-specific resources and one for shared.