commercial-emacs / commercial-emacs

"Evil will always triumph, because good is dumb." -- Spaceballs (1987)

Home Page:https://www.youtube.com/channel/UCyf-xqc0ovYSDgaCcB3CUoA/featured

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Buffer overflow

jstaursky opened this issue · comments

Really like this fork. It seems to run faster than normal emacs even with the native compilation feature compiled in. I would like to make it my main editor but whenever I try to use it with the doom emacs config it acts funny or crashes when I use SPC + s + p (search project) or when using M+? (lookup references).
(lookup references) leads to a buffer overflow in xdisp.c during a call to produce_glyphless_glyph.

The callstack goes: (truncated)

  • produce_glyphless_glyph @xdisp.c:28333
  • gui_produce_glyphs @xdisp.c:29151
  • display_sline @xdisp.c:21578
  • try_window @xdisp.c:17929
  • redisplay_window @xdisp.c:17344
  • redisplay_window_0 @xdisp.c:15272
  • internal_condition_case_1 @eval.c:1501
  • redisplay_windows @xdisp.c:15252
  • redisplay_internal @xdisp.c:14731
  • read_char @keyboard.c:2423

I know this is not due to xref as I tried the same search, and it worked fine when running emacs with -Q. I'll try and follow up after work sometime with a more complete investigation, but I figured I could at least put the info out there for now.

looks like latest pull stops the crashing.