colyseus / colyseus

⚔ Multiplayer Framework for Node.js

Home Page:https://colyseus.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug]: @colyseus/core missing 'ws'

heilmela opened this issue · comments

Context

@colyseus/core misses ws dependency.
I just upgraded on 0.15.8 and this happens:

Error: Cannot find module 'ws'
Require stack:
- /app/node_modules/@colyseus/core/build/Room.js
- /app/node_modules/@colyseus/core/build/MatchMaker.js
- /app/node_modules/@colyseus/core/build/Server.js
- /app/node_modules/@colyseus/core/build/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/app/node_modules/@colyseus/core/build/Room.js:31:25)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/app/node_modules/@colyseus/core/build/Room.js',
    '/app/node_modules/@colyseus/core/build/MatchMaker.js',
    '/app/node_modules/@colyseus/core/build/Server.js',
    '/app/node_modules/@colyseus/core/build/index.js'
  ]
}

Bug description

Colyseus core misses 'ws' dependency

Reproduction

No response

Steps to reproduce

  1. use the latest 0.15.8 @colyseus core

start minimal server

const server = createServer(app);
const gameServer = new Server({
  transport: new WebSocketTransport({
    server,
  }),
});

gameServer.listen(1234, 0.0.0.0)

Environment & Versions

Colyseus: 0.15.8
Node: 18.18.2
OS: Mac
Typescript: 5.0.4

Thanks for the feedback @heilmela, I thought ws was already entirely removed from @colyseus/core but there are still some references. The plan is to detach the core from any specific transport layer completely in the near future