collabora / WhisperLive

A nearly-live implementation of OpenAI's Whisper.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TranscriptionTeeClient __call__ ---> class methods

AIWintermuteAI opened this issue · comments

Hi, @makaveli10 !
Great job on creating this!

I like how well written and organized the code is. One thing that does seem a little bit off, as a design decision is overloading the call of the TranscriptionTeeClient. Would it make more sense to rather have explicit methods for different tasks, i.e. process_file, process_hls and process_mic ? Then each of this methods can have its own relevant args.

If this makes sense, I can make a quick PR.

@AIWintermuteAI absolutely, feel free to open a PR and keep them coming. Thanks!