Folders do not get removed when module is restructured
jonathanhodges opened this issue · comments
Say you have a modman file that looks like this.
file1.txt file1.txt
test/file2.txt test/file2.txt
file3.txt file3.txt
and you move file of file2.txt out of the test folder and so then you have a modman file that looks like this:
file1.txt file1.txt
file2.txt file2.txt
file3.txt file3.txt
After you run modman update, the test folder (which is empty and was created by modman in the first place) should be removed. If some other code has created items in this folder, you obviously would not want to remove them but since it is empty and was created by modman, modman should delete it.
This is a minor issue but it would be nice if modman cleaned up after itself.
When I need modman to cleanup broken links, I run modman clean. That will cd to your project root and do a find -L . -mount -type l to find broken links and delete them.
The links are cleaned up appropriately by modman update but the folders that were automatically created are not ever removed.
There is no elegant solution to this issue and it is a very minor one. IMO a fix is not worth the added complexity. Thanks!