cogciprocate / ocl

OpenCL for Rust

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

you are deriving `Hash` but have implemented `PartialEq` explicitly

kpp opened this issue · comments

commented

Errors from clippy:

error: you are deriving `Hash` but have implemented `PartialEq` explicitly
   --> ocl-core/src/types/abs.rs:338:30
    |
338 | #[derive(Clone, Copy, Debug, Hash, Eq)]
    |                              ^^^^
    |
    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
note: `PartialEq` implemented here
   --> ocl-core/src/types/abs.rs:378:1
    |
378 | / impl PartialEq<PlatformId> for PlatformId {
379 | |     fn eq(&self, other: &PlatformId) -> bool {
380 | |         self.0 == other.0
381 | |     }
382 | | }
    | |_^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq

error: you are deriving `Hash` but have implemented `PartialEq` explicitly
   --> ocl-core/src/types/abs.rs:400:30
    |
400 | #[derive(Clone, Copy, Debug, Hash, Eq)]
    |                              ^^^^
    |
note: `PartialEq` implemented here
   --> ocl-core/src/types/abs.rs:446:1
    |
446 | / impl PartialEq<DeviceId> for DeviceId {
447 | |     fn eq(&self, other: &DeviceId) -> bool {
448 | |         self.0 == other.0
449 | |     }
450 | | }
    | |_^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq

Removed now unnecessary manual implementations (bc88dba).

Thanks!

commented

Pushed to master without PR?

commented

Why not use github Pull Request features? Please turn on TravisCI for this repo in https://travis-ci.org/account/repositories, I will setup CI for you.