[suggestion] Low contrast in comments
rodrigojcmello opened this issue · comments
First of all, congratulations on the great theme.
Currently I have been working a lot with accessibility to the Web and the comment caught my attention a lot, his contrast is low even for me, I have no visual impairment and I have difficulty reading the comments
The contrast is 1.31 which is really very low. I added 10 lighness (hsl) to the color of the comment and the contrast has already gone to almost 2, which is still not the ideal, but it already improves the reading a lot. A contrast 3 (which is the minimum recommended for accessibility) would be almost white, and so I think it would run away from the gray idea for comments.
Thank you!
Yea I agree, I tried to go with a style that would blend the comments in with the background more so that they seemed more out of the way. But I've noticed on some screens with different color profiles they seem much darker, and on macbook retina displays it's difficult to read what was written.
I've updated the color of the comments to be a little brighter, which should be available in the next update 👍
Edit:
The new color will closely resemble the new color that you proposed.
@all-contributors add @rodrigojcmello for ideas
@brandii-co
I've put up a pull request to add @rodrigojcmello! 🎉
It's definitely much more readable for me. on my machine. This is PhpStorm 2021.1 EAP on Ubuntu 20.04:
There's nothing special about it being on the EAP - it's the same for me in stable versions and other IDEs. Ignore the background colouration on return - that's the Return Highlighter plugin. Should also say, I override the font as it's far too small on my machine. The screenshot is using JetBrainsMonoMedium Nerd Font, 14 with ligatures enabled.
Okay, so I've disabled my font override just as an experiment (and re-enabled Indent Rainbow & Rainbow brackets because I was going to do some stuff!), and the contrast is so much lower now:
This isn't resized, it's how it renders on my laptop, hence why I bump it up to 14 from 8 - I'd probably go to 11 or 12 usually but, the ligature for === isn't pretty and it's somewhat distracting when the lines aren't equally spaced)
Apologies. I think the difference is down to me tweaking things over previous weeks, and my settings are sync'd to my account. Which means, even after resetting the colour scheme back to your stock values, that settings sync kicks in and clobbers it!
I've been experimenting and came across some colors that I think fits well with the theme, the new comment and line colors for v1.1.0 look great and are definitly more visible 👍
I don't know what's going on with the comment colours on my machines. I'd disabled config sync, deleted any duplicated colour schemes, reset this one back, disabled plugins that do anything with colour, and still, the comment text is dark to begin with and then goes far lighter after a restart. I've even deleted the files on disk too with the IDE shutdown. What's strange is, even with a reset, the hex codes for block & line, doc comment > text, are all set to #ABB2BF and that's pretty bright - and matches with those earlier screen shots.
I'll uninstall the theme and pull in 1.1.0. 🤞
🎉 The issue seems to have resolved itself. 1.1.0 looks pretty nice! I don't know if my 1.0.9 install was faulty and I've jumped a few iterations as a result, or 1.1.0 has a lot of tweaks to it but, it's instantly noticeable. I'm liking the new changes!
Yup there were a lot of issues caused by transparent colors, which produced inconsistent colors on different screens, and I've done a lot of tweaks for 1.1.0, hopefully they look great 🙂