coderxio / medication-diversification

More realistic synthetic medication data.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Distribution table values should be 0.0 - 1.0

jrlegrand opened this issue · comments

Problem Statement

Per Synthea documentation:

... the values in those columns must be numeric probabilities between 0.0 - 1.0

Currently, the values are 0 - 100. So I think they need to be 0 - 1 with only a tenths decimal place.

Criteria for Success

All numbers are tenths decimal place and total to 1.0 per row.

Additional Information

https://github.com/synthetichealth/synthea/wiki/Generic-Module-Framework%3A-Transitions#table

Hm it's odd because on that page, the probabilities in the explanations are rounded to the tenths place, while the examples displayed are in the hundredths place.

Hm and their modules appear to have inconsistent rounding
Synthea-Homelessness-Module
https://synthetichealth.github.io/module-builder/#homelessness

my fear with rounding to only tenths place is the loss of granularity for drugs that have distribution < 10%. so I'll change it to the 0-1 format, and round it to 3 decimal places for readability, consistency, and hopefully some more diversity by including drugs that are used < 1% -- and we can adjust from there if needed. but happy to look further into it or take a different approach.

@kristentaytok - is this resolved with your most recent PR?

Yessir!