Can't delete file in window

Question

Can't delete file in window

ShardanaSoft opened this issue 3 years ago · comments

Hi

I was using cloudcmd and in windows is not working. Looks like this module may be faulty. I'm trying to do a pull request.

fs module return ENOENT instead of ENOTDIR in windows.

coderaiser · Answer 1 · Mon Sep 20 2021 22:48:06 GMT+0800 (China Standard Time)

Landed in v2.2.0 🎉 Is it works for you?

ShardanaSoft · Answer 2 · Tue Sep 21 2021 02:14:33 GMT+0800 (China Standard Time)

Yes it works fine!!

Can you tell me the reason why you changed the code? was a bad code? bad for testing? I would like to learn more

coderaiser · Answer 3 · Tue Sep 21 2021 17:40:13 GMT+0800 (China Standard Time)

Can you tell me the reason why you changed the code? was a bad code? bad for testing? I would like to learn more

Your code was very good, readable and has a lot of sense. The only thing I want to clarify that on windows things works differently then on linux and mac os. And according to nodejs documentation, is better to do the thing and if it not worked, do another thing because between this calls everything can change. So to be consistent with node.js way of doing things and with all other API redzip provides I changed the code this way.

Thanks a lot for you help!

ShardanaSoft · Answer 4 · Tue Sep 21 2021 22:21:05 GMT+0800 (China Standard Time)

that make sense. thanks for spending time to teach me something new.

Happy coding