Add version flag

Question

Add version flag

nhooyr opened this issue 5 years ago · comments

Quinn Rivenwell commented 5 years ago

Teddy · Answer 1 · Thu May 23 2019 02:37:37 GMT+0800 (China Standard Time)

I will open a PR for this to mimic sshcode's version flag.

Teddy · Answer 2 · Thu May 23 2019 03:08:25 GMT+0800 (China Standard Time)

@nhooyr I am assuming that I should add docs for it, right?

Quinn Rivenwell · Answer 3 · Thu May 23 2019 03:11:42 GMT+0800 (China Standard Time)

I don't think docs are necessary. Its an expected feature of all commands.

Teddy · Answer 4 · Thu May 23 2019 03:14:24 GMT+0800 (China Standard Time)

lol ok, I wrote them anyway... should I remove them? 😢

Quinn Rivenwell · Answer 5 · Thu May 23 2019 03:15:55 GMT+0800 (China Standard Time)

lmao, sorry about that. its best the docs remain lean.

Teddy · Answer 6 · Thu May 23 2019 03:17:47 GMT+0800 (China Standard Time)

Ok, no worries. will remove them. I am waiting for my other PR to get approved (I thought that I was only contributing one thing), then I'll rebase and open a PR for this as it's already done.

Quinn Rivenwell · Answer 7 · Thu May 23 2019 03:19:33 GMT+0800 (China Standard Time)

You can just create a new branch and open another PR.

Teddy · Answer 8 · Thu May 23 2019 03:20:23 GMT+0800 (China Standard Time)

I branched off my master, so it contains things for the other PR. I think that would be messy 👀