codeforcauseorg / pledge

We pledge to Code for Cause

Home Page:https://pledge.codeforcause.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unstructured list of Contributors

Suyash-Purwar opened this issue · comments

I checked the code of this project and by cross-checking the list of the contributors JSON file with the displayed cards on the site, I realized that the cards are structured by the alphabetic ordering of the name of their respective JSON file. That means, say Shubham.json is displayed first then ayush.json because "capital S" is greater than "small a" in ASCII encoding.

I made a contribution to this project a day ago and I saved my JSON file with the name suyash.json. I went to the site to check my profile card. I was confused that my profile card was not mentioned even in the part where cards with the name S were starting. I scrolled further and cards with the name starting with A again started to appear. Following that, cards with the name starting with b, c, d, etc were listed. Almost at the very last of the page, I found my card.

This can cause confusion among beginners and they might even open a pull request saying "My profile card is not displayed". The number of contributors who took the pledge is about to reach 200 and I think this can happen. In fact, I was about to open an issue too.

I think cards should be arranged in alphabetical order without being case-sensitive. It should be arranged like that regardless of whether the contributor saves their JSON file with a capital letter or not. And a side note should be there on the website saying something like "Cards are arranged in the alphabetical order of contributors name" after this issue is fixed.

Alternatively, we can just take care of the upcoming contribution by adding one more point in the create_pledge.md file stating that the JSON file must be named with only the first letter being capital so that the upcoming contributions are structured. But this would leave already made contributions unstructured.

Checking whether the first letter of the JSON file is capital or not during the time of PR can be automated with integration testing which is already in place. I am not sure about this though.

Thanks for reading! 😊

While rendering, do you think we can sort it out by name on " data.allContributorsJson.edges "

Hi , I would like to work on this issue , can you suggest me the way to get started?

hlo! I would like to work on this issue can u suggest me some tips

Hi , I would like to work on this issue , can you suggest me the way to get started?

Same here, still awaiting for their responses.

I think you guys should start and make a pull request.

How can i solve this issue

Hi, I am new here, and would like to work on the issue.
Suggest me the ways

Hi, i would like to work on this issue, can you suggest me how to get started?

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

Hi, I want to work on this issue, can you suggest me ways to get started?

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

Hey ! I would like to work on this issue.

Hi , I would like to work on this issue , can you suggest me the way to get started?

I would like to work on this issue

Hi , I would like to work on this issue , can you suggest me the way to get started?

Hi, @Shivam-45
I follow this video and I'm trying to make my first full request which I successfully done and push it on github. Now I am waiting to merge my code from your side.
Please merge it ASAP if all are good so that I feel more confident that yessss I did it.
Thankyou.

Just a new github user passing by

Hi, I am Hassan. I would like to work on this issue, can you suggest ways to get started?

I want to work on this project can you help me

Hii I would like to work on the Demo issue, can you suggest to me ways to get started?

Hi, I would like to work on this issue, can you suggest me the way to get started?

Hi, I would like to work on this issue, can you suggest me the way to get started?

Hi,i would like to work and to started of with open source thing, anyone here to guide me up?

Hi,i would like to work and to started of with open source thing, anyone here to guide me up?

HEy I would like to work on this issue

kiya bolte publllic 😎😎

Hey, I am beginner. Kindly guide me through the way forward.

How can I help you brother

hey, i would like to work in this issue

Hey Everyone. This is my first time contributing to open source.

Hi i would like to fix this issue,can you please suggest me how to start?

Hi , I would like to work on this issue , can you suggest me the way to get started?

Hi, I would like to work on this issue , can u suggest me the way to get started?