Loan Calculator Finance Tool
Rearo43 opened this issue · comments
Create a Loan Calculator in html,css and javascript.
- Add navbar in your tool's html file. You can copy the navbar from index.html.
- Add screenshot of your tool in, PR message and also in the folder of your tool
- Before Making the PR Pull the latest changes that have been made to the repository
**Note: Please Don't Make Any Changes In `index.html` AND `contributors.html` **
Add the below mention section to your PR message
Title
Number of files/folder added
Changes made
Check the options that you have completed,
I have;
- Read contibuting.md
- Followed all the guidelines
- updated readme.md
- add your name in the footer of your tool.html file (if you created length conversion tool then add your name to length.html file you created)
- provide below mentioned details if you want your name to be added in contributors.html
- mail, twitter, github profile link.
May I please be assigned to the Loan Calculator in Finance Tools?
Would you be willing to use EJS templating instead of copying all the nav bar code and other features from the index.js file? Contributors would be able to just write one line, "<%- include('../../layout/nav') %>" for example into their code. That one line would import all the navbar code to the contributors file and eliminate any risk of typos, keeping the whole site layout completely uniform. If you were into using it I would be more than happy to go through and set up the file structure and update the README with instructions. This would also make the workflow much faster and simpler.
Yes it would be great and
Would you be willing to use EJS templating instead of copying all the nav bar code and other features from the index.js file? Contributors would be able to just write one line, "<%- include('../../layout/nav') %>" for example into their code. That one line would import all the navbar code to the contributors file and eliminate any risk of typos, keeping the whole site layout completely uniform. If you were into using it I would be more than happy to go through and set up the file structure and update the README with instructions. This would also make the workflow much faster and simpler.
Yes it would be a great feature. Our team is planning on that, we will be adding the functionality of handlebars and middlewares . we will change the contributing guidelines as soon as this happens. But until then the guidelines remains the same and all the contributors have to manage with copy/paste, Because we have to also account for the beginner developers/contributors.
@Rearo43 Are you still working on this?