codediodeio / geofirex

:globe_with_meridians: :round_pushpin: Geolocation Queries with Firestore & RxJS

Home Page:https://geo-test-c92e4.firebaseapp.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

compatibility with firebase > 8.0.0

hgrewa opened this issue · comments

Any idea of how to handle the breaking change that comes with firebase 8.0.0 onward

Before 8.0.0
import * as firebase from 'firebase/app'

After 8.0.0
import firebase from 'firebase/app'

Adding geofirex to a new angular application is throwing errors like

Error: node_modules/geofirex/dist/client.d.ts:5:18 - error TS2694: Namespace '"..../node_modules/firebase/index"' has no exported member 'firestore'.

--> geopoint: fb.firestore.GeoPoint;

I tried adding "allowSyntheticDefaultImports": true to tsconfig, but that does not address the issue
Is there a workaround?

commented

Need this too.

Any update on this coming?

Repo seem dead.
I tried to modify the source but i got an error when i execute run build:

Created bundle index.cjs.js: 23.75 kB → 6.8 kB (gzip)
Created bundle index.esm.js: 23.56 kB → 6.74 kB (gzip)
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
firebase/firestore (imported by src\client.ts, src\query.ts)
created dist/index.cjs.js, dist/index.esm.js in 1.3s

I created a pull request to support firebase ^8.0.0 feel free to upvote it #204

I created a pull request to support firebase ^8.0.0 feel free to upvote it #204

How can i use your pull request in my project?

It's amazing what you did, i upvoted!

Any update here?

Is this project still maintained?