Giters

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.

Home Page:https://code-dot-org.github.io/dance-party/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Twitter image is blurry

opened this issue · comments

commented

image

can we guarantee that this shows up small rather than large?

commented

@tanyaparker can you please help figure this out w/ @Erin007

commented

Proposed fix: code-dot-org/code-dot-org#26264

This is a very localized fix just for dance party. We should fix a few other things post hour of code:

  1. The twitter:card type photo is no longer a supported type, so we should swap out any mentions of photo with either summary, summary_large_image, or player. Summary is the small side by side type. Summary large image is the large, blurry image seen above. And player is for video.

  2. Other project types are also a bit blurry (see minecraft and app lab). This could be because 1) they're being fetched as .jpg and should be .png. Fetching as .jpg applies our image compression algorithm. 2) Or the dimensions aren't the recommended dimensions for this new summary large image size. We could create new assets with the recommended dimensions. 3) Or we could also change them to summary so it's the smaller image and create a new, smaller image as well.

  3. Sharing an aquatic project still shows an old, green mc world image instead of the new, blue mc world.

commented

Switching to summary fixed the blurriness!