Giters

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.

Home Page:https://code-dot-org.github.io/dance-party/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Perpetual spinner if animation download is unsuccessful from the Finish Dialog

Erin007 opened this issue · comments

commented

Sort of similar to #489

If there is an unsuccessful animation download from the FinishDialog you get a perpetual spinner and no error message even after the attempts to fetch the animation fail (it tries 30 times). The Share Dialog eventually gives you a handy error message. We should at least have the same error message in the Finish Dialog as in the Share Dialog.

forever-spin

commented

@Hamms thoughts on this? is this something we can resolve easily? in speaking with @Erin007 we have already addressed this in one of the code paths (the share workflow, i believe).

commented

fix merged in deployment earlier today.